MDEV-39584: update help sql tables and replace KB links#5068
Merged
Conversation
grooverdan
added
the
MariaDB Foundation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates MariaDB documentation links from the old Knowledge Base to the new documentation site across the codebase, including source files, scripts, and configuration files. Feedback identifies several issues in the updated strings: a broken URL in mysys/my_largepage.c caused by a missing slash, multiple instances where /n was incorrectly used instead of the newline character \n in InnoDB storage engine files, and several spelling errors where "Documentation" was misspelled as "Documention".
grooverdan
force-pushed
the
MDEV-39584
branch
2 times, most recently
from
4dbc6c4 to
55e5dca
Compare
scripts/fill_help_tables.sql from https://github.com/mariadb-corporation/mariadb-docs/ as of 3fb208fcdfed06beb52ef9e305017de2387ff012 Other URL changes are taken from the HTTP redirection URL from the old KB. Some test cases where impacted: * ps_missed_cmds{,_bin_prot} - used a topic_id of 0 that is now used, used MAX_INT instead. * range_notembedded used the help data as a test case. As its not a stable table data, replaces with static data. Test case valid by ensuring the ANALYZE EXPLAIN and optimizer trace had the same structure. Also valided the MDEV-24739/MDEV-25069 bug fixes from where the test case originaled, when reverted, exhibited the previous behavour before the bug fixes.
Member
|
Looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated KB links to the http redirected Documenation links.
Change the help SQL tables generated from the current Docs.
Adjust a few test cases that depended on the help documention.