MDEV-39594 Assertion failure during MYSQL_BIN_LOG::recover

[dr-m]

innobase_recover_rollback_by_xid(): Add a similar condition to the one that was in innobase_rollback_by_xid() and innobase_commit_by_xid(). Also, remove the now-redundant DBUG_EXECUTE_IF fault injection and exercise this code by specifying a nonzero innodb_log_recovery_target.

This function had been introduced in #3030 which was not present in the development branch of #4405, which had been applied to the main branch in 3394a9d.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[gemini-code-assist]

Code Review

This pull request removes the innobase_xa_fail debug flag and updates the tc_heuristic_recover.test to use --innodb-log-recovery-target instead. In ha_innodb.cc, the DBUG_EXECUTE_IF blocks for innobase_xa_fail are removed, and innobase_recover_rollback_by_xid is updated to check recv_sys.rpo. Feedback suggests adding the noexcept specifier to innobase_recover_rollback_by_xid for consistency with other rollback functions.

[gemini-code-assist]

The function innobase_recover_rollback_by_xid is missing the noexcept specifier, which is present in its sibling function innobase_rollback_by_xid (line 2810). For consistency and to potentially allow for better compiler optimizations, consider adding noexcept to this function signature as well, provided it is guaranteed not to throw.

static int innobase_recover_rollback_by_xid(const XID *xid) noexcept