MDEV-39708 invalid supplier name for MariaDB's own components#5156
Conversation
Fix sbom_get_supplier() to correctly return supplier name to caller in all cases.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the cmake/generate_sbom.cmake file to ensure that the supplier variable is correctly set in the parent scope when the repository user matches MariaDB. Specifically, it adds the PARENT_SCOPE flag to the SET command for MariaDB, aligning it with the other conditional branches in the sbom_get_supplier function. There are no review comments, so I have no feedback to provide.
There was a problem hiding this comment.
Pull request overview
This PR fixes sbom_get_supplier() in the SBOM generation CMake logic so that MariaDB-owned components correctly report "MariaDB" back to the caller, aligning behavior with other branches of the function.
Changes:
- Ensure the
mariadb-corporation|mariadbsupplier branch sets the output variable inPARENT_SCOPEso the caller receives the value.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fix sbom_get_supplier() to correctly return supplier name to caller in all cases.