Upgrade to work with latest GTSAM#39
Conversation
keevindoherty
left a comment
keevindoherty
left a comment
There was a problem hiding this comment.
LGTM! Thank you for the updates! Can you just update the note in the README about GTSAM compatibility to mention latest develop (or latest major/minor GTSAM release? whichever is most appropriate) (and tack on "Thanks to @varunagrawal for bringing DC-SAM up to date with GTSAM" of course)
| /// divide by DiscreteFactor::shared_ptr f (safely) | ||
| virtual DiscreteFactor::shared_ptr operator/( | ||
| const DiscreteFactor::shared_ptr& df) const override { | ||
| throw toDecisionTreeFactor() / df; |
There was a problem hiding this comment.
This might change in the future TBH. I want to abstract out the underlying storage mechanism.
|
Updated the README. I feel like the Docker image is outdated which is why CI is failing. We have an updated docker image if you would like to use that? |
|
Thank you! |
That would be great. Happy to accept a PR if you have cycles, but it would probably be about a month before I have time to dig into it myself... |
2 participants
Bunch of updates and fixes so DCSAM works with the latest develop branch of GTSAM.
cc @keevindoherty @kurransingh