Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example for using multiple features in code-blocks #1102

Merged
merged 10 commits into from
Mar 11, 2020
Merged

Add example for using multiple features in code-blocks #1102

merged 10 commits into from
Mar 11, 2020

Conversation

Tejas2805
Copy link
Contributor

@Tejas2805 Tejas2805 commented Mar 9, 2020 •
edited
Loading

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [X] Documentation update

Fixes #1098

What is the rationale for this request?
Easier for the users to understand how to add multiple features while using code blocks.

What changes did you make? (Give an overview)
Added an example which displays how to use multiple features in code blocks.

Provide some example code that this change will affect:
N.A.

Is there anything you'd like reviewers to focus on?
N.A.

Testing instructions:
Can check the deployed preview.

Proposed commit message: (wrap lines at 72 characters)

The user will have to try out how to add multiple features when using 
code blocks.

Let's add an example regarding how to use multiple features in code
blocks so that it's easier for the user to understand.

Tejas2805 and others added 6 commits February 17, 2020 04:54
@Tejas2805
add _site to ignore list
538ff88
@Tejas2805
update highlighted text bg color
52e1afa
@Tejas2805
Merge branch 'master' of https://github.com/MarkBind/markbind
f3d3f34 
* 'master' of https://github.com/MarkBind/markbind:
  Update tests
  Allow using 'none' footer attribute in frontmatter (MarkBind#1002)
  Support line numbers for code blocks (MarkBind#991)
  2.11.0
  Update test files due to changes in PR MarkBind#982
  Update vue-strap version to v2.0.1-markbind.36
  Make highlighting bold (MarkBind#1045)
  Support markdown for header attr in dropdown (MarkBind#1029)
  Add '_site' to the ignored folders in site.json (MarkBind#1046)
  Use path.join instead of string interpolation (MarkBind#1052)
  Implement box markdown header attributes parsing (MarkBind#1025)
  Make the position of top navbar fixed (MarkBind#982)
  Exclude *.md files from being copied over on build (MarkBind#1010)

# Conflicts:
#	docs/css/main.css
@Tejas2805
Merge branch 'master' of https://github.com/MarkBind/markbind
31d0325 
* 'master' of https://github.com/MarkBind/markbind:
  2.12.0
  Update outdated test files
  Update vue-strap version to v2.0.1-markbind.37
  Fix refactor to processDynamicResources (MarkBind#1092)
  Implement lazy page building for markbind serve (MarkBind#1038)
  Add warnings for conflicting/deprecated component attribs (MarkBind#1057)
  Allow changing parameter properties (MarkBind#1075)
  Custom timezone for built-in timestamp (MarkBind#1073)
  Fix reload inconsistency when updating frontmatter (MarkBind#1068)
  Implement an api to ignore content in certain tags (MarkBind#1047)
  Enable AppVeyor CI (MarkBind#1040)
  Add heading and line highlighting to code blocks (MarkBind#1034)
  Add dividers and fix bug in siteNav (MarkBind#1063)
  Fixed navbar no longer covers modals (MarkBind#1070)
  Add copy code-block plugin (MarkBind#1043)
  Render plugins on dynamic resources (MarkBind#1051)
  Documentation for Implement no-* attributes for <box>  (MarkBind#1042)
  Migrate to bootstrap-vue popovers (MarkBind#1033)
  Refactor preprocess and url processing functions (MarkBind#1026)
  Add pageNav to Using Plugins Page (MarkBind#1062)
@Tejas2805
add example for multiple features of code blocks
fd70b7f
@Tejas2805
Update code.mbdf
f1be98a
@Tejas2805 Tejas2805 changed the title [WIP]Code blocks example Add example for using multiple features in code-blocks Mar 9, 2020
@Tejas2805
Copy link
Contributor Author

@marvinchin Can I get your review on this. Thank you for your time.

@Tejas2805 Tejas2805 marked this pull request as ready for review March 9, 2020 07:01
nbriannl
nbriannl requested changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@nbriannl nbriannl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the documentation update. All is good except for the fact there are no commas.

docs/userGuide/syntax/code.mbdf Outdated Show resolved Hide resolved
docs/userGuide/syntax/code.mbdf Outdated Show resolved Hide resolved
nbriannl
nbriannl requested changes Mar 9, 2020
View reviewed changes
docs/userGuide/syntax/code.mbdf Outdated Show resolved Hide resolved
Tejas2805 and others added 3 commits March 9, 2020 23:12
@Tejas2805 @nbriannl
Update docs/userGuide/syntax/code.mbdf
07f298f 
Co-Authored-By: nbriannl <neilbrian.nl@gmail.com>
@Tejas2805 @nbriannl
Update docs/userGuide/syntax/code.mbdf
5541ac0 
Co-Authored-By: nbriannl <neilbrian.nl@gmail.com>
@Tejas2805 @nbriannl
Update docs/userGuide/syntax/code.mbdf
b6bfaa1 
Co-Authored-By: nbriannl <neilbrian.nl@gmail.com>
@Tejas2805 Tejas2805 requested a review from nbriannl March 9, 2020 15:28
nbriannl
nbriannl requested changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@nbriannl nbriannl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for one nit. 😅

docs/userGuide/syntax/code.mbdf Outdated Show resolved Hide resolved
docs/userGuide/syntax/code.mbdf Outdated Show resolved Hide resolved
nbriannl
nbriannl approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@nbriannl nbriannl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for raising up that you couldn't understand how to use multiple features.

@marvinchin marvinchin added this to the v2.12.1 milestone Mar 11, 2020
@marvinchin marvinchin merged commit d409741 into MarkBind:master Mar 11, 2020
@Tejas2805 Tejas2805 deleted the code-blocks-example branch March 13, 2020 10:01
Tejas2805 added a commit to Tejas2805/markbind that referenced this pull request Mar 15, 2020
@Tejas2805
Merge branch 'master' of https://github.com/MarkBind/markbind
d86bf69 
* 'master' of https://github.com/MarkBind/markbind:
  Add example for using multiple features in code-blocks (MarkBind#1102)
marvinchin pushed a commit that referenced this pull request Apr 10, 2020
@Tejas2805
Add example for using multiple features in code-blocks (#1102)
85aa4f1 
The user will have to try out how to add multiple features when using 
code blocks.

Let's add an example regarding how to use multiple features in code
blocks so that it's easier for the user to understand.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinchin marvinchin marvinchin approved these changes

@nbriannl nbriannl nbriannl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.13.0
Development

Successfully merging this pull request may close these issues.

How to use multiple features for code blocks
3 participants
@Tejas2805 @marvinchin @nbriannl