Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent restoring stale cursor/selection offsets when a document’s contents are reloaded from disk due to external edits (e.g., via revert), by discarding persisted selection history in those cases.
Changes:
- Exposes
EditorDocument.hasBeenRevertedoutside the private extension so view controllers can detect recent reverts. - Adds
EditorSelectionHistory.discard(for:)to centralize removing persisted selection entries. - Discards selection history during editor reset when the document was reverted, avoiding stale offsets (especially when file-size checks are skipped).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| MarkEditMac/Sources/Editor/Models/EditorDocument.swift | Moves hasBeenReverted to the main class scope so other components can detect reverts. |
| MarkEditMac/Sources/Editor/EditorSelectionHistory.swift | Refactors selection-history removal into a reusable discard(for:) helper. |
| MarkEditMac/Sources/Editor/Controllers/EditorViewController.swift | Discards selection history when resetting the editor after a revert to avoid restoring stale offsets. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.