Skip to content

Conversation

@david-yz-liu
Copy link
Collaborator

@david-yz-liu david-yz-liu commented Aug 20, 2025

Proposed Changes

(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)

This PR fixes two issues with the assignment summary "Group" text filter:

  1. It was erroneously including a boolean "inactive" member field in the search, leading to a runtime error
  2. Its matching was case-sensitive rather than case-insensitive.

This PR fixes both of those issues.

Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue) X
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 17086134955

Details

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 91.846%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/javascript/Components/assignment_summary_table.jsx 0 4 0.0%
Totals Coverage Status
Change from base Build 17040575291: -0.002%
Covered Lines: 42121
Relevant Lines: 45146

💛 - Coveralls

@david-yz-liu david-yz-liu merged commit 899c143 into MarkUsProject:master Aug 20, 2025
5 of 7 checks passed
@david-yz-liu david-yz-liu deleted the fix-assignment-summary-group-filter branch August 20, 2025 02:08
@david-yz-liu david-yz-liu added this to the v2.8.1 milestone Aug 20, 2025
donny-wong pushed a commit to donny-wong/Markus that referenced this pull request Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants