Add last_updated_by Foreign Key To Grades and Marks Tables#7878
Merged
david-yz-liu merged 5 commits intoMarkUsProject:masterfrom Mar 30, 2026
Merged
Add last_updated_by Foreign Key To Grades and Marks Tables#7878david-yz-liu merged 5 commits intoMarkUsProject:masterfrom
david-yz-liu merged 5 commits intoMarkUsProject:masterfrom
Conversation
Collaborator
Pull Request Test Coverage Report for Build 23692078518Details
💛 - Coveralls |
Collaborator
david-yz-liu
left a comment
There was a problem hiding this comment.
@lizzie-liu this is good, but please also define the "inverse" associations within the Role class (a has_many)
david-yz-liu
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR adds a
last_updated_byforeign key column (referencingroles.id) to both the marks and grades tables. This allows instructors to track which TA (or instructor) last assigned a given grade.Changes:
last_updated_bycolumn, index, and FK constraint to both tablesMarkandGrademodels updated withbelongs_to :last_updated_byassociationRolemodel updated with inversehas_manyassociations forlast_updated_marksandlast_updated_gradeswithdependent: :nullifymark_spec.rb,grade_spec.rb, androle_spec.rbScreenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)