Skip to content

Add last_updated_by Foreign Key To Grades and Marks Tables#7878

Merged
david-yz-liu merged 5 commits intoMarkUsProject:masterfrom
lizzie-liu:add-last-updated-by
Mar 30, 2026
Merged

Add last_updated_by Foreign Key To Grades and Marks Tables#7878
david-yz-liu merged 5 commits intoMarkUsProject:masterfrom
lizzie-liu:add-last-updated-by

Conversation

@lizzie-liu
Copy link
Copy Markdown
Contributor

@lizzie-liu lizzie-liu commented Mar 25, 2026

Proposed Changes

This PR adds a last_updated_by foreign key column (referencing roles.id) to both the marks and grades tables. This allows instructors to track which TA (or instructor) last assigned a given grade.

Changes:

  • Database migration adding last_updated_by column, index, and FK constraint to both tables
    • Column is nullable with a default of null
  • Mark and Grade models updated with belongs_to :last_updated_by association
  • Role model updated with inverse has_many associations for last_updated_marks and last_updated_grades with dependent: :nullify
  • Tests added for new associations in mark_spec.rb, grade_spec.rb, and role_spec.rb
Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration) X

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Mar 25, 2026

Pull Request Test Coverage Report for Build 23692078518

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 91.713%

Totals Coverage Status
Change from base Build 23690924504: 0.001%
Covered Lines: 45168
Relevant Lines: 48441

💛 - Coveralls

@lizzie-liu lizzie-liu requested a review from david-yz-liu March 25, 2026 21:54
Copy link
Copy Markdown
Collaborator

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lizzie-liu this is good, but please also define the "inverse" associations within the Role class (a has_many)

@lizzie-liu lizzie-liu requested a review from david-yz-liu March 28, 2026 19:22
@david-yz-liu david-yz-liu merged commit e596fd4 into MarkUsProject:master Mar 30, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants