Skip to content

Update Results Controller to update last_updated_by #7885

Merged
david-yz-liu merged 3 commits intoMarkUsProject:masterfrom
lizzie-liu:set-last-updated-by
Apr 4, 2026
Merged

Update Results Controller to update last_updated_by #7885
david-yz-liu merged 3 commits intoMarkUsProject:masterfrom
lizzie-liu:set-last-updated-by

Conversation

@lizzie-liu
Copy link
Copy Markdown
Contributor

@lizzie-liu lizzie-liu commented Mar 30, 2026

Proposed Changes

This PR updates the ResultsController#update_mark method to update the last_updated_by attribute when marks are modified.

Changes

  • Set last_updated_by to the current user during mark updates in ResultsController#update_mark
  • Updated tests in results_controller_spec.rb
Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration) X

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Mar 30, 2026

Pull Request Test Coverage Report for Build 23764168704

Details

  • 1 of 4 (25.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 91.707%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spec/controllers/results_controller_spec.rb 0 3 0.0%
Totals Coverage Status
Change from base Build 23747917452: -0.006%
Covered Lines: 45168
Relevant Lines: 48444

💛 - Coveralls

@lizzie-liu lizzie-liu requested a review from david-yz-liu March 30, 2026 20:12
Copy link
Copy Markdown
Collaborator

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lizzie-liu!

@david-yz-liu david-yz-liu merged commit 4d5fccc into MarkUsProject:master Apr 4, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants