Skip to content

Refactored tables to cache column definitions#7910

Merged
david-yz-liu merged 1 commit intomasterfrom
table-column-refactoring
Apr 18, 2026
Merged

Refactored tables to cache column definitions#7910
david-yz-liu merged 1 commit intomasterfrom
table-column-refactoring

Conversation

@david-yz-liu
Copy link
Copy Markdown
Collaborator

@david-yz-liu david-yz-liu commented Apr 17, 2026

Proposed Changes

(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)

This PR modifies how columns are passed to react table. Previously, several of our table components recreated a columns object on every render, which triggered a re-render of the underling ReactTable/Table component. Now, the columns are computed as part of the component state and only updated when its prop/state dependencies change.

Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality) X
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@david-yz-liu david-yz-liu force-pushed the table-column-refactoring branch 2 times, most recently from 24a2fc8 to f948f71 Compare April 18, 2026 01:29
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Apr 18, 2026

Coverage Report for CI Build 24606792320

Coverage decreased (-0.004%) to 91.719%

Details

  • Coverage decreased (-0.004%) from the base build.
  • Patch coverage: 52 uncovered changes across 7 files (77 of 129 lines covered, 59.69%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
app/javascript/Components/groups_manager.jsx 51 26 50.98%
app/javascript/Components/graders_manager.jsx 22 10 45.45%
app/javascript/Components/Modals/release_urls_modal.jsx 8 2 25.0%
app/javascript/Components/submission_table.jsx 6 3 50.0%
app/javascript/Components/test_group_result_table.jsx 23 20 86.96%
app/javascript/Components/assignment_summary_table.jsx 6 4 66.67%
app/javascript/Components/course_summaries_table.jsx 10 9 90.0%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 48549
Covered Lines: 45270
Line Coverage: 93.25%
Relevant Branches: 1854
Covered Branches: 959
Branch Coverage: 51.73%
Branches in Coverage %: Yes
Coverage Strength: 130.52 hits per line

💛 - Coveralls

@david-yz-liu david-yz-liu force-pushed the table-column-refactoring branch from f948f71 to d5b82b6 Compare April 18, 2026 02:47
@david-yz-liu david-yz-liu force-pushed the table-column-refactoring branch from d5b82b6 to 036af36 Compare April 18, 2026 14:30
@david-yz-liu david-yz-liu merged commit 8bbae83 into master Apr 18, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants