Skip to content

Moved annotation-related Javascript to be bundled with webpack#7953

Merged
david-yz-liu merged 1 commit into
masterfrom
annotations-js-refactor
May 16, 2026
Merged

Moved annotation-related Javascript to be bundled with webpack#7953
david-yz-liu merged 1 commit into
masterfrom
annotations-js-refactor

Conversation

@david-yz-liu
Copy link
Copy Markdown
Collaborator

@david-yz-liu david-yz-liu commented May 16, 2026

Proposed Changes

(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)

This PR moves existing JS files under app/assets/javascripts/Annotations to app/javascript/common/annotations and uses module imports rather than exposing all definitions globally. This also includes these files to be bundled with webpack.

Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality) X
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@coveralls
Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 25972161540

Coverage decreased (-1.6%) to 90.173%

Details

  • Coverage decreased (-1.6%) from the base build.
  • Patch coverage: 153 uncovered changes across 5 files (4 of 157 lines covered, 2.55%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
app/javascript/common/annotations/pdf_annotation_manager.js 153 4 2.61%
app/javascript/Components/Result/html_viewer.jsx 1 0 0.0%
app/javascript/Components/Result/image_viewer.jsx 1 0 0.0%
app/javascript/Components/Result/pdf_viewer.jsx 1 0 0.0%
app/javascript/Components/Result/text_viewer.jsx 1 0 0.0%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 49606
Covered Lines: 45700
Line Coverage: 92.13%
Relevant Branches: 2151
Covered Branches: 971
Branch Coverage: 45.14%
Branches in Coverage %: Yes
Coverage Strength: 128.1 hits per line

💛 - Coveralls

@david-yz-liu david-yz-liu merged commit 36ad6e2 into master May 16, 2026
9 of 11 checks passed
@david-yz-liu david-yz-liu deleted the annotations-js-refactor branch May 16, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants