Skip to content

Added unique database indexes to enforce model uniqueness validations#8018

Merged
david-yz-liu merged 1 commit into
masterfrom
added-unique-indexes
Jun 22, 2026
Merged

Added unique database indexes to enforce model uniqueness validations#8018
david-yz-liu merged 1 commit into
masterfrom
added-unique-indexes

Conversation

@david-yz-liu

@david-yz-liu david-yz-liu commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Proposed Changes

(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)

This pull request updates our database indexes to enforce uniqueness constraints (aligned with model validations) and remove unnecessary indexes. This follows the active_record_doctor missing-unique-indexes and extraneous-indexes checks.

Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality) X
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

- Enforce model uniqueness validations
- Remove redundant indexes

These were deteted by active_redord_doctor:missing_unique_indexes and active_record_doctor:extraneous_indexes.
@david-yz-liu david-yz-liu force-pushed the added-unique-indexes branch from 646db0e to f5abbdf Compare June 22, 2026 02:09
@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 27925235631

Coverage increased (+0.001%) to 90.267%

Details

  • Coverage increased (+0.001%) from the base build.
  • Patch coverage: 3 of 3 lines across 1 file are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 50437
Covered Lines: 46515
Line Coverage: 92.22%
Relevant Branches: 2309
Covered Branches: 1097
Branch Coverage: 47.51%
Branches in Coverage %: Yes
Coverage Strength: 127.17 hits per line

💛 - Coveralls

@david-yz-liu david-yz-liu merged commit 174c586 into master Jun 22, 2026
11 checks passed
@david-yz-liu david-yz-liu deleted the added-unique-indexes branch June 22, 2026 15:21
akarki2005 pushed a commit to akarki2005/Markus that referenced this pull request Jun 23, 2026
- Enforce model uniqueness validations
- Remove redundant indexes

These were detected by active_record_doctor:missing_unique_indexes and active_record_doctor:extraneous_indexes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants