Skip to content

Fix test assertions and lint issues in workflow/API tests#71

Merged
MarkusNeusinger merged 2 commits intoclaude/add-workflow-api-tests-01F3xWa4yNDwsSYAN5rv6W7xfrom
copilot/sub-pr-70
Nov 30, 2025
Merged

Fix test assertions and lint issues in workflow/API tests#71
MarkusNeusinger merged 2 commits intoclaude/add-workflow-api-tests-01F3xWa4yNDwsSYAN5rv6W7xfrom
copilot/sub-pr-70

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Nov 30, 2025

Several test assertions were always-true, providing no actual validation. Fixed these to perform meaningful checks.

Changes

  • test_workflows.py: Fixed workflow name matching to use substring comparison instead of len(file_words) == 1 fallback that always passed for single-word filenames
  • test_workflows.py: Removed unused has_fetch_depth variable (lint fix)
  • test_prompts.py: Fixed empty section detection regex to properly validate section content
  • test_main.py: Fixed CORS test to verify headers exist and reject error status codes
  • pyproject.toml: Downgraded requires-python from >=3.14 to >=3.13 (3.14 unreleased)

Example fix

# Before: always passes for single-word filenames
has_relation = len(overlap) > 0 or has_substring_match or len(file_words) == 1

# After: meaningful validation
has_relation = len(overlap) > 0 or has_substring_match

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: MarkusNeusinger <2921697+MarkusNeusinger@users.noreply.github.com>
Copilot AI changed the title [WIP] Add comprehensive unit tests for workflows and APIs Fix test assertions and lint issues in workflow/API tests Nov 30, 2025
@MarkusNeusinger MarkusNeusinger marked this pull request as ready for review November 30, 2025 20:38
@MarkusNeusinger MarkusNeusinger merged commit 407462c into claude/add-workflow-api-tests-01F3xWa4yNDwsSYAN5rv6W7x Nov 30, 2025
@MarkusNeusinger MarkusNeusinger deleted the copilot/sub-pr-70 branch November 30, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants