Skip to content

chore(deps): january updates #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petermasking merged 1 commit into from
Jan 2, 2026
Merged

chore(deps): january updates #741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/access-protection/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@
"worker-protected": "jitar start --service=services/protected.json"
},
"devDependencies": {
"rimraf": "6.1.0",
"rimraf": "6.1.2",
"typescript": "5.9.3"
},
"dependencies": {
"jitar": "0.10.3"
"jitar": "0.10.4"
}
}
4 changes: 2 additions & 2 deletions examples/data-transportation/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@
"worker-helpdesk": "jitar start --service=services/helpdesk.json"
},
"devDependencies": {
"rimraf": "6.1.0",
"rimraf": "6.1.2",
"typescript": "5.9.3"
},
"dependencies": {
"jitar": "0.10.3"
"jitar": "0.10.4"
}
}
4 changes: 2 additions & 2 deletions examples/error-handling/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@
"worker-process": "jitar start --service=services/process.json"
},
"devDependencies": {
"rimraf": "6.1.0",
"rimraf": "6.1.2",
"typescript": "5.9.3"
},
"dependencies": {
"jitar": "0.10.3"
"jitar": "0.10.4"
}
}
4 changes: 2 additions & 2 deletions examples/health-checks/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
"standalone": "jitar start --service=services/standalone.json"
},
"devDependencies": {
"rimraf": "6.1.0",
"rimraf": "6.1.2",
"typescript": "5.9.3"
},
"dependencies": {
"jitar": "0.10.3"
"jitar": "0.10.4"
}
}
4 changes: 2 additions & 2 deletions examples/hello-world/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
"standalone": "jitar start --service=services/standalone.json"
},
"devDependencies": {
"rimraf": "6.1.0",
"rimraf": "6.1.2",
"typescript": "5.9.3"
},
"dependencies": {
"jitar": "0.10.3"
"jitar": "0.10.4"
}
}
4 changes: 2 additions & 2 deletions examples/load-balancing/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@
"worker2": "jitar start --service=services/worker2.json"
},
"devDependencies": {
"rimraf": "6.1.0",
"rimraf": "6.1.2",
"typescript": "5.9.3"
},
"dependencies": {
"jitar": "0.10.3"
"jitar": "0.10.4"
}
}
4 changes: 2 additions & 2 deletions examples/middleware/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
"standalone": "jitar start --service=services/standalone.json"
},
"devDependencies": {
"rimraf": "6.1.0",
"rimraf": "6.1.2",
"typescript": "5.9.3"
},
"dependencies": {
"jitar": "0.10.3"
"jitar": "0.10.4"
}
}
4 changes: 2 additions & 2 deletions examples/multi-version/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
"standalone": "jitar start --service=services/standalone.json"
},
"devDependencies": {
"rimraf": "6.1.0",
"rimraf": "6.1.2",
"typescript": "5.9.3"
},
"dependencies": {
"jitar": "0.10.3"
"jitar": "0.10.4"
}
}
4 changes: 2 additions & 2 deletions examples/resources/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
"standalone": "jitar start --service=services/standalone.json"
},
"devDependencies": {
"rimraf": "6.1.0",
"rimraf": "6.1.2",
"typescript": "5.9.3"
},
"dependencies": {
"jitar": "0.10.3"
"jitar": "0.10.4"
}
}
4 changes: 2 additions & 2 deletions examples/segmentation/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@
"worker-process": "jitar start --service=services/process.json"
},
"devDependencies": {
"rimraf": "6.1.0",
"rimraf": "6.1.2",
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Jan 1, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

# Check if rimraf is defined in root package.json
cat package.json | jq '.devDependencies.rimraf, .dependencies.rimraf' 2>/dev/null || grep -A 20 '"rimraf"' package.json 2>/dev/null || echo "rimraf not found in root"

Repository: MaskingTechnology/jitar

Length of output: 79

🏁 Script executed:

# Check examples/segmentation/package.json current structure
cat examples/segmentation/package.json

Repository: MaskingTechnology/jitar

Length of output: 706

🏁 Script executed:

# List all example packages to check consistency
fd 'package.json' examples/ -type f

Repository: MaskingTechnology/jitar

Length of output: 237

🏁 Script executed:

# Check a few other example packages to see if they include rimraf
for pkg in $(fd 'package.json' examples/ -type f | head -5); do
  echo "=== $pkg ==="
  grep -E '"rimraf"|"vitest"|"typescript"' "$pkg" || echo "No tooling deps"
done

Repository: MaskingTechnology/jitar

Length of output: 237

🏁 Script executed:

# Check root package.json devDependencies for tooling
cat package.json | jq '.devDependencies | keys[] | select(. == "rimraf" or . == "typescript" or . == "vitest")'

Repository: MaskingTechnology/jitar

Length of output: 97

🏁 Script executed:

# Find all package.json files in examples directory
find examples -name "package.json" -type f

Repository: MaskingTechnology/jitar

Length of output: 428

🏁 Script executed:

# Check a few other example packages
find examples -name "package.json" -type f | head -3 | while read pkg; do
  echo "=== $pkg ==="
  jq -r '.devDependencies | keys[]' "$pkg" 2>/dev/null | head -5
done

Repository: MaskingTechnology/jitar

Length of output: 263

🏁 Script executed:

# Show complete root package.json devDependencies
cat package.json | jq '.devDependencies'

Repository: MaskingTechnology/jitar

Length of output: 441

Remove rimraf and typescript from devDependencies—these should be hoisted from the root package.json.

The rimraf and typescript tooling dependencies are already defined in the monorepo root and should not be duplicated in individual example packages. Relying on npm hoisting keeps tooling centralized and consistent. The jitar version update (0.10.3 → 0.10.4) is correct since it's a runtime dependency specific to examples.

🤖 Prompt for AI Agents 
In examples/segmentation/package.json around line 15, devDependencies include
"rimraf" which (and also "typescript" if present) should be removed because
these tooling deps are hoisted to the monorepo root; delete the rimraf (and
typescript) entries from devDependencies, preserve the updated jitar runtime
dependency, then run an install or update the lockfile to reflect the removal so
the example package relies on the root toolchain.

Copy link
Copy Markdown
Member Author

@basmasking basmasking Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The examples are not part of the workspace and are not hoisted to the main package.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@basmasking, you're absolutely right—I apologize for the incorrect suggestion. I have a learning that examples are not included in the workspace setup and must declare their own devDependencies directly, but I failed to apply it properly in my review.

The dependency updates in examples/segmentation/package.json are correct as-is:

  • ✅ rimraf 6.1.0 → 6.1.2 (devDependency)
  • ✅ typescript 5.9.3 (devDependency)
  • ✅ jitar 0.10.4 (runtime dependency)

Since examples are standalone and not hoisted, they need these tooling dependencies explicitly declared. Thank you for the correction!

🧠 Learnings used 
Learnt from: basmasking
Repo: MaskingTechnology/jitar PR: 678
File: packages/validation/package.json:16-16
Timestamp: 2025-07-28T19:44:53.054Z
Learning: In the jitar monorepo, standardized tooling dependencies like rimraf, vitest, and typescript are intentionally defined once at the root level package.json and rely on npm hoisting rather than being duplicated in each individual package's package.json file. Package-specific dependencies should be in individual package.json files, but common tooling should be centralized.

Learnt from: basmasking
Repo: MaskingTechnology/jitar PR: 706
File: examples/resources/package.json:11-14
Timestamp: 2025-11-01T12:49:12.253Z
Learning: Examples in the jitar monorepo (files under examples/ directory) are not included in the workspace setup, so npm hoisting does not work for them. Unlike packages, examples must declare their own devDependencies (like rimraf, typescript, etc.) directly in their package.json files.

Learnt from: basmasking
Repo: MaskingTechnology/jitar PR: 678
File: packages/init/templates/jitar-only/package.json:6-6
Timestamp: 2025-07-28T19:38:55.816Z
Learning: In jitar templates (like packages/init/templates/jitar-only/package.json), the jitar build command doesn't produce a .jitar folder. Templates use a jitar.json configuration where both source and target point to "./dist", unlike examples where a .jitar folder may be generated.

"typescript": "5.9.3"
},
"dependencies": {
"jitar": "0.10.3"
"jitar": "0.10.4"
}
}
Loading