Skip to content

Claude/whoop app fork improvements 897f7b - #1

Merged
MatB57 merged 2 commits into
mainfrom
claude/whoop-app-fork-improvements-897f7b
Aug 12, 2026
Merged

Claude/whoop app fork improvements 897f7b#1
MatB57 merged 2 commits into
mainfrom
claude/whoop-app-fork-improvements-897f7b

Conversation

@MatB57

@MatB57 MatB57 commented Aug 12, 2026

Copy link
Copy Markdown
Owner

What this PR does

Type of change

  • Bug fix
  • New feature
  • Refactor / cleanup
  • Documentation
  • CI / tooling

How it was tested

Checklist

  • Swift package tests pass for any package I touched (swift test in Packages/<name>)
  • Android unit tests pass if I touched android/ (./gradlew testFullDebugUnitTest)
  • No new build warnings introduced
  • UI changes use only StrandDesign tokens — no hardcoded colors, fonts, or spacing
  • No hardcoded hex frame bytes; protocol facts live in the schema / decoders
  • Follows the conventions in docs/CONTRIBUTING.md
  • I did not commit generated output (Strand.xcodeproj/) or any secrets/keystores

Related issues

noaetmatthias and others added 2 commits August 12, 2026 18:05
The in-app update checkers (macOS + Android), AltStore/SideStore source
metadata, bug-report links, and install/README docs all still pointed at
ParthJadhav/noop. Retarget them at MatB57/noop so future releases published
here are the ones this fork's users (and their sideloaded devices) actually
discover and auto-update to.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
French was ~15% complete on the main catalog (458/2988 keys) and partial
elsewhere. Fills in all remaining keys across the four Xcode string
catalogs (Strand, NOOPWatch, NOOPWatchComplications, StrandDesign) and adds
the missing android/values-fr/strings.xml, matching the established
"vous"-register terminology already used in the existing French strings
(Récupération, Effort, VFC, Bracelet, Sources de données, etc.).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@ecc-tools

ecc-tools Bot commented Aug 12, 2026

Copy link
Copy Markdown

Analyzing 200 commits...

@MatB57
MatB57 merged commit f0b6c01 into main Aug 12, 2026
@ecc-tools

ecc-tools Bot commented Aug 12, 2026

Copy link
Copy Markdown

Analysis Complete

Generated ECC bundle from 2 commits | Confidence: 50%

View Pull Request #2

Repository Profile
Attribute Value
Language Swift
Framework Not detected
Commit Convention freeform
Test Directory separate
Changed Files (15)
Metric Value
Files changed 15
Additions 15876
Deletions 20

Top hotspots

Path Status +/-
Strand/Resources/Localizable.xcstrings modified +15174 / -0
NOOPWatch/Localizable.xcstrings modified +228 / -0
Packages/StrandDesign/Sources/StrandDesign/Resources/Localizable.xcstrings modified +216 / -0
NOOPWatchComplications/Localizable.xcstrings modified +162 / -0
android/app/src/main/res/values-fr/strings.xml added +76 / -0

Top directories

Directory Files Total changes
Strand/Resources 1 15174
NOOPWatch 1 228
Packages/StrandDesign/Sources/StrandDesign/Resources 1 216
NOOPWatchComplications 1 162
android/app/src/main/res/values-fr 1 76
Analysis Depth Readiness (commit-history, 7%)

ECC Tools uses this to decide whether recommendations should stay at commit-history/setup guidance or expand into CI, security, harness, reference-set, AI-routing, and team backlog work.

Area Status Evidence / Next Step
Commit history Partial 2 commits sampled
CI/CD signals Missing Add workflow files or CI troubleshooting evidence so ECC Tools can reason about pipeline setup.
Security evidence Missing Add AgentShield, audit, SARIF, SBOM, or security review evidence so recommendations can cover security posture.
Harness configuration Missing Add Claude, Codex, OpenCode, Zed, dmux, MCP, plugin, or cross-harness config evidence for harness-agnostic recommendations.
Reference/eval evidence Missing Add fixtures, golden traces, reference sets, or evaluator benchmarks so deeper recommendations have regression evidence.
AI routing and cost controls Missing Add model-routing, budget, usage, or cost-control files before relying on AI-heavy automation recommendations.
Team handoff and project tracking Missing Add roadmap, runbook, project, Linear, or follow-up tracking docs so generated work can land in a team queue.
Reference Set Readiness (0/7, 0%)
Area Status Evidence / Next Step
Deep analyzer corpus Missing Add analyzer fixture, golden, benchmark, or reference-set files that can catch analyzer regressions.
RAG/evaluator comparison Missing Add retrieval or evaluator reference-set comparison fixtures with expected ranking behavior.
PR salvage/review corpus Missing Add stale-PR, review-thread, reopen-flow, or salvage reference cases for queue cleanup automation.
Discussion triage corpus Missing Add public discussion triage fixtures, golden cases, or reference sets for informational, answered, and no-response classifications.
Harness compatibility Missing Add cross-harness, adapter-compliance, or harness-audit evidence for Claude, Codex, OpenCode, Zed, dmux, and agent surfaces.
Security evidence Missing Attach security evidence such as SBOMs, SARIF, audit reports, or AgentShield evidence packs.
CI failure-mode evidence Missing Add captured CI failure logs, dry-run fixtures, or troubleshooting docs for common workflow failure modes.
Likely Future Issues (2)
Severity Signal Why it may show up
HIGH Regression coverage may lag behind the diff 3 generic code paths changed; 0 test files changed
MEDIUM User-facing UI changes may ship without browser coverage 1 user-facing UI paths changed; 0 browser or e2e coverage files changed
  • Regression coverage may lag behind the diff: The PR changes multiple code paths but does not touch any obvious test files.
  • User-facing UI changes may ship without browser coverage: The PR changes components, pages, or other user-facing UI files without touching any obvious browser or end-to-end coverage.
Suggested Follow-up Work (2)
Type Suggested title Targets
PR test: add regression coverage for android/app/src/main/java/com/noop/testcentre/TestReportLink.kt + android/app/src/main/java/com/noop/ui/SettingsScreen.kt android/app/src/main/java/com/noop/testcentre/TestReportLink.kt, android/app/src/main/java/com/noop/ui/SettingsScreen.kt
PR test: add browser coverage for android/app/src/main/java/com/noop/ui/SettingsScreen.kt android/app/src/main/java/com/noop/ui/SettingsScreen.kt
  • test: add regression coverage for android/app/src/main/java/com/noop/testcentre/TestReportLink.kt + android/app/src/main/java/com/noop/ui/SettingsScreen.kt: Backfill regression coverage before another change set lands on the touched code paths.
  • test: add browser coverage for android/app/src/main/java/com/noop/ui/SettingsScreen.kt: Backfill browser coverage before another user-facing UI change lands on the touched surface.

Copy-ready bodies

test: add regression coverage for android/app/src/main/java/com/noop/testcentre/TestReportLink.kt + android/app/src/main/java/com/noop/ui/SettingsScreen.kt

## Summary
- Add regression coverage for the recently touched code paths before more changes stack on top.

## Why
- Backfill regression coverage before another change set lands on the touched code paths.

## Touched paths
- `android/app/src/main/java/com/noop/testcentre/TestReportLink.kt`
- `android/app/src/main/java/com/noop/ui/SettingsScreen.kt`

## Validation
- Add or extend focused tests that exercise the touched paths.
- Run the affected test suite and verify the new coverage closes the gap.

test: add browser coverage for android/app/src/main/java/com/noop/ui/SettingsScreen.kt

## Summary
- Add browser or end-to-end coverage for the recently changed user-facing surface.

## Why
- Backfill browser coverage before another user-facing UI change lands on the touched surface.

## Touched paths
- `android/app/src/main/java/com/noop/ui/SettingsScreen.kt`

## Validation
- Add or extend browser / e2e coverage for the changed component, page, or flow.
- Exercise the visible user journey that depends on the touched UI surface.
Generated Instincts (5)
Domain Count
git 1
code-style 3
testing 1

After merging, import with:

/instinct-import .claude/homunculus/instincts/inherited/noop-instincts.yaml

Files

  • .claude/ecc-tools.json
  • .claude/skills/noop/SKILL.md
  • .agents/skills/noop/SKILL.md
  • .agents/skills/noop/agents/openai.yaml
  • .claude/identity.json
  • .codex/config.toml
  • .codex/AGENTS.md
  • .codex/agents/explorer.toml
  • .codex/agents/reviewer.toml
  • .codex/agents/docs-researcher.toml
  • .claude/homunculus/instincts/inherited/noop-instincts.yaml

ECC Tools | Everything Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants