Skip to content

Position DatePicker and TimePicker popups below input fields#4052

Merged
Keboo merged 2 commits into
masterfrom
keboo/position-popups-below-input-fields
May 15, 2026
Merged

Position DatePicker and TimePicker popups below input fields#4052
Keboo merged 2 commits into
masterfrom
keboo/position-popups-below-input-fields

Conversation

@Keboo
Copy link
Copy Markdown
Member

@Keboo Keboo commented May 15, 2026

Date and time picker popups were using a custom placement callback that could obscure the selected value. This change aligns picker behavior with the expected default by opening below the input field in normal layouts.

What changed

  • Switched DatePicker and TimePicker template popup placement from Custom to Bottom.
  • Removed the now-unused CustomPopupPlacementCallbackHelper.
  • Added UI coverage for both controls to assert the popup opens below the text box by default.

Notes for reviewers

  • This intentionally relies on normal WPF popup fallback behavior, so placement can still flip when there is not enough space below.

Fixes: #4050

Keboo and others added 2 commits May 14, 2026 22:40
Fixes issue #4050 by using Bottom popup placement for DatePicker and TimePicker templates, removing the unused custom popup callback helper, and adding UI tests that assert the popup opens below the text box by default.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Keboo Keboo merged commit b081885 into master May 15, 2026
2 checks passed
@Keboo Keboo deleted the keboo/position-popups-below-input-fields branch May 15, 2026 06:39
@Keboo Keboo added this to the 5.3.3 milestone May 15, 2026
@Keboo Keboo added the visual breaking change Items here have affected the visual look of controls. label May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

visual breaking change Items here have affected the visual look of controls.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant