storage: introduce dyncfg, and shift one config over #26076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danhhz
reviewed
Mar 15, 2024
| enable_dependency_read_hold_asserts: config.enable_dependency_read_hold_asserts(), | ||
| user_storage_managed_collections_batch_duration: config | ||
| .user_storage_managed_collections_batch_duration(), | ||
| dyncfg_updates: Some(config.dyncfg_updates()), |
Contributor
There was a problem hiding this comment.
this makes the copy in PersistParameters above redundant, we should probably remove that one
persist: PersistParameters {
config_updates: config.dyncfg_updates(),
},
Contributor
Author
There was a problem hiding this comment.
I was able to delete this AND PersistParameters entirely!
ParkMyCar
approved these changes
Mar 18, 2024
rjobanp
approved these changes
Mar 18, 2024
Contributor
rjobanp
left a comment
rjobanp
left a comment
There was a problem hiding this comment.
Just some nits to leave some better in-code comments explaining the semantics of when we populate the dyncfg_updates field and when we don't
Contributor
Author
|
@rjobanp added some comments! merging! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly copied #25513, but with 2 differences:
Arc<ConfigSet>because in storage rendering we clone theStorageConfigurationstruct for convenience.StorageParametersin memory in the storage controller and each worker in the storage state, as opposed to copying all the fields into another struct. In this case, I just leftdyncfg_updatesNone.Motivation
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.