persist: Wire Parquet dictionary encoding and compression to LaunchDarkly#28678
Merged
danhhz merged 4 commits intoMaterializeInc:mainfrom Aug 1, 2024
Merged
persist: Wire Parquet dictionary encoding and compression to LaunchDarkly#28678danhhz merged 4 commits intoMaterializeInc:mainfrom
LaunchDarkly#28678danhhz merged 4 commits intoMaterializeInc:mainfrom
Conversation
danhhz
approved these changes
Jul 31, 2024
Contributor
danhhz
left a comment
There was a problem hiding this comment.
We should circle back and remove some of the compile time deps once we settle on something, but otherwise LGTM
2ecf471 to
57c87ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two dyncfgs for Parquet encoding, one to enable dictionary encoding and a second to enable compression.
Motivation
Parquet supports dictionary encoding and compression which can both seriously reduce the size of the encoded data. We need to run benchmarks to determine if we should enable these features, adding these dyncfgs is the first step in doing that.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.