Skip to content

bin/scratch: Fix mypy type#31477

Merged
def- merged 1 commit intoMaterializeInc:mainfrom
def-:pr-fix-bin-scratch
Feb 13, 2025
Merged

bin/scratch: Fix mypy type#31477
def- merged 1 commit intoMaterializeInc:mainfrom
def-:pr-fix-bin-scratch

Conversation

@def-
Copy link
Contributor

@def- def- commented Feb 13, 2025

Follow-up to #31410

Noticed by Jan in https://materializeinc.slack.com/archives/CM7ATT65S/p1739439309198359

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@def- def- requested a review from teskje February 13, 2025 09:43
@def- def- enabled auto-merge February 13, 2025 09:43
Copy link
Contributor

@teskje teskje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@def- def- merged commit 8231239 into MaterializeInc:main Feb 13, 2025
7 checks passed
@def- def- deleted the pr-fix-bin-scratch branch February 13, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants