adapter: properly retry when LD client initialization fails #32030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teskje
commented
Mar 28, 2025
Comment on lines
73
to
75
| if tokio::time::timeout(config_sync_timeout, init) | ||
| .await | ||
| .is_err() |
Contributor
Author
There was a problem hiding this comment.
The timeout error handling here also looks very suspicious to me. We just log an INFO event, but the LD sync might be broken. Shouldn't we at least return an error?
Previously the code initializing the LD client would correctly await `initialized_async` to see if the initialization succeeded. However, if it didn't succeed it would simply wait a bit and then call `initialized_async` again. Reading the LD server sdk code, there is no reason to assume that the call would return something different if repeated. This commit changes the logic to call `start_with_default_executor` again when `initialized_async` reports failure, to attempt a new initialization. It also moves to the mz-ore `Retry` type, instead of implementing manual retry logic.
ParkMyCar
approved these changes
Apr 2, 2025
Comment on lines
73
to
75
| if tokio::time::timeout(config_sync_timeout, init) | ||
| .await | ||
| .is_err() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the code initializing the LD client would correctly await
initialized_asyncto see if the initialization succeeded. However, if it didn't succeed it would simply wait a bit and then callinitialized_asyncagain. Reading the LD server sdk code, there is no reason to assume that the call would return something different if repeated.This PR changes the logic to call
start_with_default_executoragain wheninitialized_asyncreports failure, to attempt a new initialization. It also moves to the mz-oreRetrytype, instead of implementing manual retry logic.Motivation
If initializing the LD client fails the first time, the code gets stuck forever in a retry loop.
Tips for reviewer
I only stumbled over this when reading the code and I might be missing something. Please check my work!
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.