Skip to content

Conversation

@ggevay
Copy link
Contributor

@ggevay ggevay commented May 20, 2025

This PR just adds some comments and renames a function to make it more clear whether redaction happens, and therefore whether they can be used to print plans in prod logs.

cc @jasonhernandez

Motivation

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@ggevay ggevay requested a review from a team as a code owner May 20, 2025 15:52
@ggevay ggevay added the A-CLUSTER Topics related to the CLUSTER layer label May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CLUSTER Topics related to the CLUSTER layer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant