EXPLAIN ANALYZE for indexes and materialized views
#32555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgree
force-pushed
the
explain-analyze
branch
2 times, most recently
from
caa0dce to
46c1ae7
Compare
…h led to query hardening lol]
kay-kim
reviewed
May 30, 2025
| AND mz_now() >= a.end_time | ||
| ORDER BY a.id, b.amount DESC, b.bid_time, b.buyer; | ||
|
|
||
| CREATE INDEX wins_by_item ON winning_bids (item); |
Contributor
There was a problem hiding this comment.
So ... running explain analyze for index works but if I update to create a materialized view and run explain analyze for mat view, I get lagging objects. Using one of the mzbuild from this pr.
Oh, ne'er mind. It came back after 263.03s.
Contributor
There was a problem hiding this comment.
Added a patch for some docs tweak. I left the transform-data/optimization page alone for now because that page needs a bit more rewrite.
antiguru
approved these changes
Jun 4, 2025
Member
antiguru
left a comment
antiguru
left a comment
There was a problem hiding this comment.
Looks good. One stray edit which we should remove before merging.
src/sql-parser/src/parser.rs
Outdated
| Some(ExplainFormat::VerboseText) | ||
| } | ||
| None => return Err(ParserError::new(self.index, "expected a format")), | ||
| None => return Err(ParserError::new(self.index, "exTected a format")), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pair programmed with @antiguru.
Adds support for:
Generates appropriate queries to
mz_introspectionviews, effectively blessing certain introspection queries.Motivation
https://github.com/MaterializeInc/database-issues/issues/6551
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.