Skip to content

Conversation

@frankmcsherry
Copy link
Contributor

We have a single error to log which uses multiple lines in Rust, but without a \ at the end of the line, so that the logged message misses the rest of the error.

Motivation

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@frankmcsherry frankmcsherry requested a review from a team as a code owner May 23, 2025 18:13
Copy link
Member

@antiguru antiguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; looks good.

Co-authored-by: Moritz Hoffmann <antiguru@gmail.com>
@frankmcsherry frankmcsherry enabled auto-merge (squash) June 9, 2025 13:47
@frankmcsherry frankmcsherry merged commit e7be060 into MaterializeInc:main Jun 9, 2025
82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants