Skip to content

Conversation

@alex-hunt-materialize
Copy link
Contributor

@alex-hunt-materialize alex-hunt-materialize commented May 29, 2025

The kubernetes examples repo moved almost everything into an _archived directory kubernetes/examples@3ae9fb0 .

This PR locks our minio install yamls to the commit before they were moved.

We should eventually swap to some supported yamls and/or reevaluate our use of minio, but for now this should fix the nightly tests.

Motivation

  • This PR fixes a previously unreported bug.
    Many nightly tests are failing.
failed on setup with "subprocess.CalledProcessError: Command '['kubectl', '--context', 'kind-mzcloud', '--namespace', 'default', 'create', '-f', 'https://raw.githubusercontent.com/kubernetes/examples/master/staging/storage/minio/minio-standalone-deployment.yaml']' returned non-zero exit status 1."

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@alex-hunt-materialize alex-hunt-materialize marked this pull request as ready for review May 29, 2025 17:18
@alex-hunt-materialize alex-hunt-materialize requested review from a team as code owners May 29, 2025 17:18
@alex-hunt-materialize
Copy link
Contributor Author

alex-hunt-materialize commented May 29, 2025

I've verified that it fixes cloudtest. The other failures are the same error, so should also be fixed.
https://buildkite.com/materialize/nightly/builds/12148#01971cfc-6c0e-4605-a3bd-3572f93eed0a

@alex-hunt-materialize alex-hunt-materialize merged commit 8240642 into MaterializeInc:main May 29, 2025
14 checks passed
@alex-hunt-materialize alex-hunt-materialize deleted the fix_minio_install branch May 29, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants