Skip to content

Conversation

@teskje
Copy link
Contributor

@teskje teskje commented May 30, 2025

Resetting the PartitionedComputeState upon seeing a CreateTimely command is not necessary. Both sides of the controller-replica connections throw away their existing partitioned state and create a new instance when the connection fails, implicitly resetting the state.

Motivation

  • This PR refactors existing code.

Pulled out from #31710.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

Resetting the `PartitionedComputeState` upon seeing a `CreateTimely`
command is not necessary. Both sides of the controller-replica
connections throw away their existing partitioned state and create a new
instance when the connection fails, implicitly resetting the state.
@teskje teskje marked this pull request as ready for review June 2, 2025 08:04
@teskje teskje requested a review from a team as a code owner June 2, 2025 08:04
@teskje teskje requested a review from antiguru June 2, 2025 11:13
@teskje teskje merged commit a38df45 into MaterializeInc:main Jun 2, 2025
272 of 274 checks passed
@teskje
Copy link
Contributor Author

teskje commented Jun 2, 2025

TFTR!

@teskje teskje deleted the partitioned-no-reset branch July 23, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants