Skip to content

Conversation

@ParkMyCar
Copy link
Contributor

This PR adds support for compressed webhook bodies using the decompression layers in tower_http. It also adds a test to ensure the decompression actually works.

Motivation

More advance support for webhook bodies.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@ParkMyCar ParkMyCar requested review from a team as code owners May 30, 2025 16:13
@ParkMyCar ParkMyCar requested a review from aljoscha May 30, 2025 16:13
@ParkMyCar ParkMyCar force-pushed the webhook/decompress-bodies branch from ac6806a to 882b691 Compare May 30, 2025 16:15
@ParkMyCar ParkMyCar force-pushed the webhook/decompress-bodies branch from 882b691 to 43f9a50 Compare June 2, 2025 20:25
@teskje teskje self-assigned this Jun 13, 2025
@teskje
Copy link
Contributor

teskje commented Jun 13, 2025

Thanks @ParkMyCar! I'll take over getting this merged if you don't mind.

@teskje teskje force-pushed the webhook/decompress-bodies branch 3 times, most recently from aea6036 to d8a67e4 Compare June 16, 2025 08:55
@def- def- force-pushed the webhook/decompress-bodies branch from d8a67e4 to a600c4f Compare June 16, 2025 10:53
@def-
Copy link
Contributor

def- commented Jun 16, 2025

Rebased to deal with Hetzner not having aarch64 availability (to pick my improved detection and AWS fallback): https://buildkite.com/materialize/test/builds/104777

@teskje Oops, I think you have to reopen this yourself:

Checking whether GitHub user ParkMyCar is a member of the code-authorized team

@teskje teskje force-pushed the webhook/decompress-bodies branch from a600c4f to 5e2cbc5 Compare June 16, 2025 16:15
@teskje teskje requested a review from a team as a code owner June 16, 2025 16:15
@teskje
Copy link
Contributor

teskje commented Jun 16, 2025

Manual rebuild still works!

@teskje teskje force-pushed the webhook/decompress-bodies branch from 5e2cbc5 to db1cb88 Compare June 16, 2025 16:31
To avoid a duplicate brotli dependency.
@teskje teskje force-pushed the webhook/decompress-bodies branch from db1cb88 to 73269bf Compare June 16, 2025 16:49
@teskje teskje enabled auto-merge June 16, 2025 17:05
@teskje teskje merged commit 1ef593c into MaterializeInc:main Jun 16, 2025
84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants