[webhooks] increase the HTTP requst body limit to 5MiB #32612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ey get logged properly
ptravers
reviewed
May 30, 2025
|
|
||
| /// Maximum allowed size for a request. | ||
| pub const MAX_REQUEST_SIZE: usize = u64_to_usize(2 * bytesize::MB); | ||
| pub const MAX_REQUEST_SIZE: usize = u64_to_usize(5 * bytesize::MIB); |
Contributor
There was a problem hiding this comment.
only concern is switching to mebibytes. is it worth just remaining on megabytes?
Contributor
There was a problem hiding this comment.
can we add a comment noting why we use mebibytes? also will need a doc change, I guess?
Contributor
There was a problem hiding this comment.
I think so (in terms of updating the docs).
https://materialize.com/docs/sql/create-source/webhook/#request-limits
Contributor
Author
There was a problem hiding this comment.
Good call out, I updated the docs!
ptravers
approved these changes
May 30, 2025
Contributor
ptravers
left a comment
ptravers
left a comment
There was a problem hiding this comment.
thought more about it and it makes sense to use base 2 rather than base 10 for a network request. envoy also works on mebi from memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases the HTTP request body limit from 2MB to 5MiB. The original 2MB limit was picked arbitrarily and it should be safe to bump the limit up.
It also updates an existing test to ensure we'll get logging in prometheus if a request gets rejected for too large of a body.
Motivation
Support larger webhook payloads
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.