*: disallow using Iterator::zip#33472
Merged
petrosagg merged 9 commits intoMaterializeInc:mainfrom Sep 4, 2025
Merged
Conversation
petrosagg
force-pushed
the
forbid-iterator-zip
branch
7 times, most recently
from
a4fdd52 to
8555f40
Compare
petrosagg
force-pushed
the
forbid-iterator-zip
branch
2 times, most recently
from
b95cb87 to
10649ab
Compare
antiguru
approved these changes
Sep 2, 2025
Member
antiguru
left a comment
antiguru
left a comment
There was a problem hiding this comment.
Looks good, and has surprisingly few special cases!
petrosagg
force-pushed
the
forbid-iterator-zip
branch
from
10649ab to
9e80000
Compare
petrosagg
force-pushed
the
forbid-iterator-zip
branch
from
9e80000 to
3258cc3
Compare
Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
The resulting iterator of `.zip_eq` does not implement `DoubleEndedIterator`.
Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
petrosagg
force-pushed
the
forbid-iterator-zip
branch
from
3258cc3 to
bbcd9ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As discussed recently with the cluster team,
Iterator::zipcan be a footgun when early stopping isn't anticipated or desirable. This PR marks the method as disallowed and switches all uses toItertools::zip_eqwhich panics if the two iterators are not the same length.During this process one bug was found! The fix is in the first commit.
The subsequent commits are in descending order of "boring", with the last two being simply adding the required
use itertools::Itertoolsstatements and adding the deny rule. Those are also quite a bit of the diff so I highly recommend reviewing commit by commit.Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.