[Prototype] Self Managed OIDC Authentication#34516
Draft
SangJunBak wants to merge 1 commit intoMaterializeInc:mainfrom
Draft
[Prototype] Self Managed OIDC Authentication#34516SangJunBak wants to merge 1 commit intoMaterializeInc:mainfrom
SangJunBak wants to merge 1 commit intoMaterializeInc:mainfrom
Conversation
aljoscha
reviewed
Dec 18, 2025
| include_www_authenticate_header, | ||
| }); | ||
| } | ||
| Authenticator::Oidc(oidc) => match creds { |
Contributor
There was a problem hiding this comment.
very preliminary comment: but I think with the number of authenticators growing, we should maybe put this behind an interface, maybe make Authenticator compatible with trait Objects, but at least we could move this big match statement to the authenticator crate.
Contributor
There was a problem hiding this comment.
not really a comment about your PR but the general state here 😅
aljoscha
reviewed
Dec 18, 2025
| let auth_session = pending().right_future(); | ||
| (session, auth_session) | ||
| } | ||
| Authenticator::Oidc(oidc) => { |
Contributor
There was a problem hiding this comment.
same comment as above, I'm hopeful we can factor this whole match statement out into authenticator crate or maybe put behind dyn objects
Contributor
Author
There was a problem hiding this comment.
I was thinking that too! Definitely some common traits between this and the frontegg authenticator.
9c74475 to
264800b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To try:
demo.mov
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.