[10057] [Planner] Treat empty int2vector as 1 dimensional #34981
+124
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pre-merge checklist
|
mtabebe
requested review from
ggevay
and removed request for
a team and
ohbadiah
antiguru
reviewed
Feb 11, 2026
src/repr/src/adt/array.rs
Outdated
Comment on lines
51
to
56
| /// Returns true if this array's dimensions are valid for the Int2Vector type. | ||
| /// Int2Vector is 1-D; empty arrays use 0 dimensions (PostgreSQL convention). | ||
| pub fn has_int2vector_dims(array: &Array<'_>) -> bool { | ||
| array.dims().len() == 1 || (array.dims().len() == 0 && array.elements().iter().next().is_none()) | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Can we make this a function on Array? It's hard to keep track of free standing functions, and this seems to be highly specific to arrays.
Contributor
Author
There was a problem hiding this comment.
Sure, there didn't seem to be a ton of function on the Array struct. But I'm happy to move it.
mtabebe
force-pushed
the
ma/10057/int2vec-dims
branch
from
6416405 to
01aa3e6
Compare
mtabebe
force-pushed
the
ma/10057/int2vec-dims
branch
2 times, most recently
from
09c7f48 to
a0a92bc
Compare
ggevay
approved these changes
Feb 11, 2026
antiguru
approved these changes
Feb 12, 2026
Member
antiguru
left a comment
antiguru
left a comment
There was a problem hiding this comment.
Looks good, left a minor comment inline. Thank you!
src/repr/src/adt/array.rs
Outdated
|
|
||
| #[cfg(test)] | ||
| mod tests { | ||
| use std::iter; |
Member
There was a problem hiding this comment.
Nit: import std::iter::empty as this is the only thing you're using from the module, or write std::iter::empty in all call sites.
Problem: Panic arise in the execution/optimization with empty int2vector's ``` ERROR: internal error: internal error in optimizer: internal transform error int2vector dimensions differ: got datum with dimension 0, expected dimension 1 ``` Solution: Introduce has_int2vector_dims which validates either the array is 1-dimensional, or 0 dimensional, and empty. Use this in 3 places where checked Testing: New tests in int2vector.slt that test empty int2vector's, or rows with empty vector's
mtabebe
force-pushed
the
ma/10057/int2vec-dims
branch
from
a0a92bc to
355857c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Panics arise in the execution/optimization with empty int2vector's
Solution:
Introduce has_int2vector_dims which validates either the array is 1-dimensional, or 0 dimensional, and empty. Use this in 3 places where checked
Testing:
New tests in int2vector.slt that test empty int2vector's, or rows with empty vector's
Motivation
https://github.com/MaterializeInc/database-issues/issues/10057