expr: Remove lifetime from eager unary functions#35031
Merged
antiguru merged 2 commits intoMaterializeInc:mainfrom Feb 17, 2026
Merged
expr: Remove lifetime from eager unary functions#35031antiguru merged 2 commits intoMaterializeInc:mainfrom
antiguru merged 2 commits intoMaterializeInc:mainfrom
Conversation
Move the lifetime parameter from `EagerUnaryFunc<'a>` to GATs on the associated types (`Input<'a>`, `Output<'a>`) and the `call` method. This enables more flexible lifetime handling in implementations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>
Contributor
Pre-merge checklist
|
antiguru
changed the title
petrosagg
approved these changes
Feb 17, 2026
patrickwwbutler
pushed a commit
to patrickwwbutler/materialize
that referenced
this pull request
Feb 19, 2026
Moves the lifetime parameter for `EagerUnaryFunc` from the trait to the associated types. This wasn't possible when we first implemented the traits. No behavior changes expected. The first commit contains the trait changes, the second the updated sqlfunc snapshots. --------- Signed-off-by: Moritz Hoffmann <mh@materialize.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the lifetime parameter for
EagerUnaryFuncfrom the trait to the associated types. This wasn't possible when we first implemented the traits. No behavior changes expected. The first commit contains the trait changes, the second the updated sqlfunc snapshots.