Skip to content

console: fix Role Filters in dark mode#35131

Merged
leedqin merged 1 commit intoMaterializeInc:mainfrom
leedqin:fixRolesFilterDarkModeBug
Mar 2, 2026
Merged

console: fix Role Filters in dark mode#35131
leedqin merged 1 commit intoMaterializeInc:mainfrom
leedqin:fixRolesFilterDarkModeBug

Conversation

@leedqin
Copy link
Contributor

@leedqin leedqin commented Feb 20, 2026

Remove these sections if your commit already has a good description!

Motivation

Fixes this
image

After the fix
image

Description

RoleFilter was spreading buildReactSelectFilterStyles(...) and overriding the theme styles

Verification

Screenshots added for verification

@github-actions
Copy link

Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone.

PR title guidelines

  • Use imperative mood: "Fix X" not "Fixed X" or "Fixes X"
  • Be specific: "Fix panic in catalog sync when controller restarts" not "Fix bug" or "Update catalog code"
  • Prefix with area if helpful: compute: , storage: , adapter: , sql:

Pre-merge checklist

  • The PR title is descriptive and will make sense in the git log.
  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).

@leedqin leedqin requested a review from SangJunBak February 20, 2026 17:13
@leedqin leedqin changed the title Fix Role Filters in dark mode console: fix Role Filters in dark mode Feb 20, 2026
@leedqin leedqin force-pushed the fixRolesFilterDarkModeBug branch from 83afb45 to a6a8413 Compare March 2, 2026 20:59
@leedqin leedqin requested review from a team, aljoscha, ggevay and teskje as code owners March 2, 2026 20:59
@leedqin leedqin force-pushed the fixRolesFilterDarkModeBug branch from a6a8413 to 25eeb41 Compare March 2, 2026 21:09
@leedqin leedqin enabled auto-merge (squash) March 2, 2026 21:33
@leedqin leedqin merged commit ea220f9 into MaterializeInc:main Mar 2, 2026
119 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants