[skill] Add mz-pr-review skill for local PR review#35217
Merged
mtabebe merged 1 commit intoMaterializeInc:mainfrom Feb 26, 2026
Merged
[skill] Add mz-pr-review skill for local PR review#35217mtabebe merged 1 commit intoMaterializeInc:mainfrom
mtabebe merged 1 commit intoMaterializeInc:mainfrom
Conversation
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
antiguru
reviewed
Feb 26, 2026
.claude/skills/mz-pr-review/SKILL.md
Outdated
|
|
||
| ## Steps | ||
|
|
||
| 1. Parse arguments from: $ARGUMENTS — optional base branch to diff against (default: `main`). |
Member
There was a problem hiding this comment.
Another option is to use gh diff PR, which doesn't require interacting with git.
Contributor
Author
There was a problem hiding this comment.
Cool I'll add something about this. I'll fix up
antiguru
approved these changes
Feb 26, 2026
aljoscha
approved these changes
Feb 26, 2026
Contributor
aljoscha
left a comment
There was a problem hiding this comment.
I use jujutsu, not git, for determining the diff and things, but this should work for everyone
Contributor
Author
Makes sense. IMO we should merge without jj support and then you can fix up with alternative instructions. |
Add a Claude skill that runs a local code review against Materialize standards. To do so it: diffs against a base branch, then checks the change against tests (including Rust unit tests), code style, errors, architecture, and polish. Findings are reported as Blocking / Strong suggestions / Nits. The checklist aligns with doc/developer/guide-changes.md and guide-testing.md. To test: run `/mz-pr-review`
8c65ff8 to
8ff6790
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a Claude skill that runs a local code review against Materialize standards. To do so it: diffs against a base branch, then checks the change against tests (including Rust unit tests), code style, errors, architecture, and polish.
Findings are reported as Blocking / Strong suggestions / Nits.
The checklist aligns with doc/developer/guide-changes.md and guide-testing.md.
To test: run
/mz-pr-review