sql: Enable cast elimination by default#35296
Merged
ggevay merged 2 commits intoMaterializeInc:mainfrom Mar 5, 2026
Merged
Conversation
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
78b7b9e to
816f732
Compare
Contributor
Author
|
Thanks for the rewrites, looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add testing coverage after #35084; to prepare for rollout.
Description
Turn on
enable_cast_eliminationby default. Rewrite SLTs (eliminatingvarchar_to_textand reordering some filter clauses; usegit diff --word-diff --word-diff-regex=.for a readable diff).Verification
Existing tests failed; rewritten to get things green. Adding nightly and release verification runs, as well.