Skip to content

sql: Enable cast elimination by default#35296

Merged
ggevay merged 2 commits intoMaterializeInc:mainfrom
ggevay:cast-elim-exp
Mar 5, 2026
Merged

sql: Enable cast elimination by default#35296
ggevay merged 2 commits intoMaterializeInc:mainfrom
ggevay:cast-elim-exp

Conversation

@ggevay
Copy link
Contributor

@ggevay ggevay commented Mar 2, 2026

Motivation

Add testing coverage after #35084; to prepare for rollout.

Description

Turn on enable_cast_elimination by default. Rewrite SLTs (eliminating varchar_to_text and reordering some filter clauses; use git diff --word-diff --word-diff-regex=. for a readable diff).

Verification

Existing tests failed; rewritten to get things green. Adding nightly and release verification runs, as well.

@github-actions
Copy link

github-actions bot commented Mar 2, 2026

Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone.

PR title guidelines

  • Use imperative mood: "Fix X" not "Fixed X" or "Fixes X"
  • Be specific: "Fix panic in catalog sync when controller restarts" not "Fix bug" or "Update catalog code"
  • Prefix with area if helpful: compute: , storage: , adapter: , sql:

Pre-merge checklist

  • The PR title is descriptive and will make sense in the git log.
  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).

@ggevay ggevay added the A-optimization Area: query optimization and transformation label Mar 2, 2026
@ggevay ggevay force-pushed the cast-elim-exp branch 2 times, most recently from 78b7b9e to 816f732 Compare March 4, 2026 16:12
@mgree mgree changed the title DNM Enable cast elimination by default sql: Enable cast elimination by default Mar 4, 2026
@mgree mgree marked this pull request as ready for review March 4, 2026 17:42
@mgree mgree requested a review from a team as a code owner March 4, 2026 17:42
@mgree mgree requested a review from ohbadiah March 4, 2026 17:42
Copy link
Contributor

@mgree mgree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (Will have @ggevay get eyes on this as well.)

@ggevay ggevay enabled auto-merge (squash) March 5, 2026 10:34
@ggevay ggevay merged commit 1c57435 into MaterializeInc:main Mar 5, 2026
126 checks passed
@ggevay
Copy link
Contributor Author

ggevay commented Mar 5, 2026

Thanks for the rewrites, looks good!

Turned on also in LD for the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-optimization Area: query optimization and transformation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants