[SS-44] Add COPY FROM s3 Docs#35301
Conversation
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
martykulma
left a comment
There was a problem hiding this comment.
Nice! The doc should also enumerate the S3 bucket/object ACLs needed for MZ to read the data.
|
@kay-kim would you be able to review these today? aiming to launch to customers tomorrow. if you're stretched thin, let me know and I can review |
|
I'll take a look when I get into the office. Wanted to print out the draft freshness guide, so needed home printer. |
| Read* | [`s3:GetObject`](https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetObject.html) | Grants permission to retrieve an object from a bucket. | ||
|
|
||
| {{< note >}} | ||
| *Read - The `s3:GetObject` Read action is only required if you wish to perform bulk imports into Materialize using [`COPY FROM s3`](/sql/copy-from/). |
There was a problem hiding this comment.
Q: This sink to s3 using COPY TO s3 page ... Why are we including COPY FROM s3 here?
There was a problem hiding this comment.
I figured it wouldn't hurt to add it as this is the main source of info on how to set up AWS connections, and then just added the asterisk to note that it's only required if you want to use COPY FROM. I figured it couldn't hurt?
There was a problem hiding this comment.
Heh ... it'll be confusing for users who are sinking to S3 ... because it'll make people go "is this me? Will this tutorial make me do a COPY FROM step later?
It might be that we instead need an ingest data > Bulk copy page. Will let @maheshwarip decide (doesn't actually need to be a blocker but something on the backlog). Yeah ... our connections page is shenanigans.
There was a problem hiding this comment.
In discussing, we can do the tutorial when we do parquet and we'll go with just the reference page. As such, I would just revert any changes to this tutorial.
| Read* | [`s3:GetObject`](https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetObject.html) | Grants permission to retrieve an object from a bucket. | ||
|
|
||
| {{< note >}} | ||
| *Read - The `s3:GetObject` Read action is only required if you wish to perform bulk imports into Materialize using [`COPY FROM s3`](/sql/copy-from/). |
There was a problem hiding this comment.
Heh ... it'll be confusing for users who are sinking to S3 ... because it'll make people go "is this me? Will this tutorial make me do a COPY FROM step later?
It might be that we instead need an ingest data > Bulk copy page. Will let @maheshwarip decide (doesn't actually need to be a blocker but something on the backlog). Yeah ... our connections page is shenanigans.
doc/user/content/sql/copy-from.md
Outdated
| | Read | [`s3:GetObject`](https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetObject.html) | Grants permission to retrieve an object from a bucket. | | ||
| | List | [`s3:ListBucket`](https://docs.aws.amazon.com/AmazonS3/latest/API/API_ListObjectsV2.html) | Grants permission to list some or all of the objects in a bucket. | | ||
|
|
||
| As we are not writing to the bucket, we do not need any write permissions, only read and list. |
There was a problem hiding this comment.
We don't need this sentence.
doc/user/content/sql/copy-from.md
Outdated
| ### S3 Bucket IAM Policies | ||
|
|
||
| To prepare your S3 bucket for bulk import, follow the instructions in the [Amazon S3 Sink guide](/serve-results/sink/s3), | ||
| but, in your IAM policy, instead allow these actions: |
There was a problem hiding this comment.
Yeah ... I would just specify that you need to allow these in your IAM policy. Depending on product's answer w.r.t. a tutorial, we can point people to that whenever that's done.
There was a problem hiding this comment.
Since no tutorial for now, just say you need to allow the following in your IAM policy.
I can't reply to the parent comment for some reason. It is odd, but let's not block this PR. we can add the bulk copy page later |
|
@kay-kim ready for review! |
Updates the documentation for `COPY FROM` mzsql command to include information and syntax on the new `COPY FROM s3` feature. ### Motivation https://linear.app/materializeinc/issue/SS-44/write-user-facing-docs-for-copy-from-s3-statement-csv ### Description Adds a new syntax file for copy from s3/url, adds tab to SQL command reference page, and information on how to use it. --------- Co-authored-by: Pranshu Maheshwari <pranshu.maheshwari@materialize.com>
Updates the documentation for
COPY FROMmzsql command to include information and syntax on the newCOPY FROM s3feature.Motivation
https://linear.app/materializeinc/issue/SS-44/write-user-facing-docs-for-copy-from-s3-statement-csv
Description
Adds a new syntax file for copy from s3/url, adds tab to SQL command reference page, and information on how to use it.