Skip to content

Revert "[adapter] Batch-allocate user IDs to reduce persist writes du…#35447

Merged
mtabebe merged 1 commit intoMaterializeInc:mainfrom
mtabebe:ma/revert/7cd382606
Mar 12, 2026
Merged

Revert "[adapter] Batch-allocate user IDs to reduce persist writes du…#35447
mtabebe merged 1 commit intoMaterializeInc:mainfrom
mtabebe:ma/revert/7cd382606

Conversation

@mtabebe
Copy link
Contributor

@mtabebe mtabebe commented Mar 12, 2026

@mtabebe mtabebe requested review from aljoscha and def- March 12, 2026 12:43
@mtabebe mtabebe requested review from a team as code owners March 12, 2026 12:43
@github-actions
Copy link

Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone.

PR title guidelines

  • Use imperative mood: "Fix X" not "Fixed X" or "Fixes X"
  • Be specific: "Fix panic in catalog sync when controller restarts" not "Fix bug" or "Update catalog code"
  • Prefix with area if helpful: compute: , storage: , adapter: , sql:

Pre-merge checklist

  • The PR title is descriptive and will make sense in the git log.
  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).

Copy link
Contributor

@def- def- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also reenable the tests in ci/nightly/ that have a skip due to this issue

@mtabebe mtabebe merged commit 42be526 into MaterializeInc:main Mar 12, 2026
128 checks passed
mtabebe added a commit to mtabebe/materialize that referenced this pull request Mar 12, 2026
This change was reverted (MaterializeInc#35447)
so no need to skip anymore
def- pushed a commit that referenced this pull request Mar 12, 2026
This change was reverted
(#35447) so no need to
skip anymore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants