envd/tests: ignore ID changes in datadriven ws tests#35510
Merged
teskje merged 1 commit intoMaterializeInc:mainfrom Mar 17, 2026
Merged
envd/tests: ignore ID changes in datadriven ws tests#35510teskje merged 1 commit intoMaterializeInc:mainfrom
teskje merged 1 commit intoMaterializeInc:mainfrom
Conversation
Contributor
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
def-
reviewed
Mar 16, 2026
teskje
force-pushed
the
ws-datadriven-less-churn
branch
from
ba5211a to
a43b8ee
Compare
Contributor
Author
I don't think that's a good place. Note that the |
teskje
force-pushed
the
ws-datadriven-less-churn
branch
from
a43b8ee to
e0379ca
Compare
This is a minimal change to reduce the churn on the datadriven ws tests whenever IDs change in the catalog. Like for timestamps, we simply replace all occurrences of IDs by running a regex. More flexible approaches, like allowing wildcards for skipping fields have been considered, but likely require changes to the `datadriven` crate.
teskje
force-pushed
the
ws-datadriven-less-churn
branch
from
e0379ca to
c45c02c
Compare
ggevay
approved these changes
Mar 17, 2026
Contributor
ggevay
left a comment
ggevay
left a comment
There was a problem hiding this comment.
Great, thank you for solving this annoying issue!
Contributor
Author
|
TFTRs! |
antiguru
added a commit
to antiguru/materialize
that referenced
this pull request
Mar 18, 2026
Rename `mz_compute_prometheus_metrics` to `mz_cluster_prometheus_metrics` since the source exposes process-wide metrics, not compute-specific ones. Fix operator timing: wake at interval boundaries to avoid drift, and only scrape when the scrape interval has elapsed. Add comment about data staleness when the scrape interval exceeds the logging interval. Restore `src/environmentd/tests/testdata/http/ws` to upstream to avoid reverting the fixid changes from PR MaterializeInc#35510. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
antiguru
added a commit
to antiguru/materialize
that referenced
this pull request
Mar 18, 2026
Rename `mz_compute_prometheus_metrics` to `mz_cluster_prometheus_metrics` since the source exposes process-wide metrics, not compute-specific ones. Fix operator timing: wake at interval boundaries to avoid drift, and only scrape when the scrape interval has elapsed. Add comment about data staleness when the scrape interval exceeds the logging interval. Restore `src/environmentd/tests/testdata/http/ws` to upstream to avoid reverting the fixid changes from PR MaterializeInc#35510. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
antiguru
added a commit
to antiguru/materialize
that referenced
this pull request
Mar 18, 2026
Rename `mz_compute_prometheus_metrics` to `mz_cluster_prometheus_metrics` since the source exposes process-wide metrics, not compute-specific ones. Fix operator timing: wake at interval boundaries to avoid drift, and only scrape when the scrape interval has elapsed. Add comment about data staleness when the scrape interval exceeds the logging interval. Restore `src/environmentd/tests/testdata/http/ws` to upstream to avoid reverting the fixid changes from PR MaterializeInc#35510. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
maheshwarip
pushed a commit
that referenced
this pull request
Mar 19, 2026
This is a minimal change to reduce the churn on the datadriven ws tests whenever IDs change in the catalog. Like for timestamps, we simply replace all occurrences of IDs by running a regex. More flexible approaches, like allowing wildcards for skipping fields have been considered, but likely require changes to the `datadriven` crate.
antiguru
pushed a commit
to antiguru/materialize
that referenced
this pull request
Mar 26, 2026
…35510) This is a minimal change to reduce the churn on the datadriven ws tests whenever IDs change in the catalog. Like for timestamps, we simply replace all occurrences of IDs by running a regex. More flexible approaches, like allowing wildcards for skipping fields have been considered, but likely require changes to the `datadriven` crate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minimal change to reduce the churn on the datadriven ws tests whenever IDs change in the catalog. Like for timestamps, we simply replace all occurrences of IDs by running a regex.
More flexible approaches, like allowing wildcards for skipping fields have been considered, but likely require changes to the
datadrivencrate.Motivation
Discussion in Slack.