Skip to content

storage: avoid division by zero in probe ticker#35565

Merged
teskje merged 1 commit intoMaterializeInc:mainfrom
teskje:probe-ticker-clamp
Mar 20, 2026
Merged

storage: avoid division by zero in probe ticker#35565
teskje merged 1 commit intoMaterializeInc:mainfrom
teskje:probe-ticker-clamp

Conversation

@teskje
Copy link
Contributor

@teskje teskje commented Mar 20, 2026

Clamp the tick interval of probe::Ticker to 1ms, to avoid a potential division by zero in round_to_interval.

Motivation

Found by bugbot: #31072 (comment)

Clamp the tick interval of `probe::Ticker` to 1ms, to avoid a potential
division by zero in `round_to_interval`.
@teskje teskje requested a review from a team as a code owner March 20, 2026 11:33
@github-actions
Copy link

Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone.

PR title guidelines

  • Use imperative mood: "Fix X" not "Fixed X" or "Fixes X"
  • Be specific: "Fix panic in catalog sync when controller restarts" not "Fix bug" or "Update catalog code"
  • Prefix with area if helpful: compute: , storage: , adapter: , sql:

Pre-merge checklist

  • The PR title is descriptive and will make sense in the git log.
  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).

Copy link
Contributor

@martykulma martykulma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @teskje !

@teskje
Copy link
Contributor Author

teskje commented Mar 20, 2026

TFTR!

@teskje teskje merged commit 8dca3c6 into MaterializeInc:main Mar 20, 2026
128 checks passed
@teskje teskje deleted the probe-ticker-clamp branch March 20, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants