Fix panic when dropping CT with active subscribe#35566
Merged
ggevay merged 1 commit intoMaterializeInc:mainfrom Mar 20, 2026
Merged
Fix panic when dropping CT with active subscribe#35566ggevay merged 1 commit intoMaterializeInc:mainfrom
ggevay merged 1 commit intoMaterializeInc:mainfrom
Conversation
When dropping a continual task, the CT's name was not recorded in dropped_item_names. This caused a panic in apply_catalog_implications_inner when an active subscribe or pending peek depended on the dropped CT, because the code tried to look up the name to include in the error message. Fix by inserting the CT's full_name into dropped_item_names, matching the pattern used by all other drop handlers (tables, sources, MVs, sinks, indexes). Co-authored-by: Junie <junie@jetbrains.com>
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When dropping a continual task, the CT's name was not recorded in dropped_item_names. This caused a panic in
apply_catalog_implications_inner when an active subscribe or pending peek depended on the dropped CT, because the code tried to look up the name to include in the error message.
Fix by inserting the CT's full_name into dropped_item_names, matching the pattern used by all other drop handlers (tables, sources, MVs, sinks, indexes).
Spotted by Cursor Bugbot: #29673 (comment)