don't install certificate watchers unless cert-manager exists#35578
Merged
doy-materialize merged 1 commit intoMaterializeInc:mainfrom Mar 20, 2026
Merged
don't install certificate watchers unless cert-manager exists#35578doy-materialize merged 1 commit intoMaterializeInc:mainfrom
doy-materialize merged 1 commit intoMaterializeInc:mainfrom
Conversation
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
|
|
||
| let crd_api: Api<CustomResourceDefinition> = Api::all(client.clone()); | ||
| let crds = crd_api.list(&ListParams::default()).await?; | ||
| let has_cert_manager = crds |
Contributor
There was a problem hiding this comment.
if cert manager gets installed at the same time / later, will this never try to watch resources?
Contributor
Author
There was a problem hiding this comment.
yeah, although that's easy enough to fix by just bouncing orchestratord, and the only impact of that is that if you try to manually edit an orchestratord-created certificate, it won't automatically revert the edit, which is not a particularly big deal
Alphadelta14
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
potential fix for https://github.com/MaterializeInc/database-issues/issues/11225 - it at least clears up the 404 errors, not entirely clear if those were actually the cause of the slowdown, but even if not it'll make it easier to dig further if necessary
Description
we were unconditionally setting up watchers for Certificate resources on our custom resource controllers since those controllers can sometimes create Certificate resources, but if we are running in an environment which doesn't use certificates, cert-manager might not be installed at all, causing an error when we try to set up a watcher for its resources.
Verification
ran
bin/mzcompose --find orchestratord run documentation-defaultslocally with this change and it appeared to work correctly.