MySQL Source Versioning using FULL binlog_row_metadata SS-71 SS-67#35598
Merged
patrickwwbutler merged 10 commits intoMaterializeInc:mainfrom Apr 7, 2026
Merged
MySQL Source Versioning using FULL binlog_row_metadata SS-71 SS-67#35598patrickwwbutler merged 10 commits intoMaterializeInc:mainfrom
patrickwwbutler merged 10 commits intoMaterializeInc:mainfrom
Conversation
Contributor
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
patrickwwbutler
changed the title
patrickwwbutler
changed the title
patrickwwbutler
force-pushed
the
patrick/mysql-sv
branch
from
58b9028 to
bf6a586
Compare
Alphadelta14
approved these changes
Apr 2, 2026
martykulma
reviewed
Apr 3, 2026
Contributor
martykulma
left a comment
martykulma
left a comment
There was a problem hiding this comment.
looks great @patrickwwbutler ! I had some comments, the most important of which is providing the reasoning for the conditional treatment of row in decoding.rs.
bosconi
added a commit
that referenced
this pull request
Apr 7, 2026
binlog-backward-compat.td (from #35598) sets binlog_row_metadata to MINIMAL but never restores it. When sharded together with upstream-schema-changes.td (also from #35598), the purification check added in #35839 rejects CREATE TABLE FROM SOURCE because the MySQL server is still in MINIMAL mode. Failure seen in https://buildkite.com/materialize/test/builds/120130#019d6892-80d9-4ae8-b919-814f200dc7ba Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bosconi
added a commit
that referenced
this pull request
Apr 7, 2026
binlog-backward-compat.td (from #35598) sets binlog_row_metadata to MINIMAL but never restores it. When sharded together with upstream-schema-changes.td (also from #35598), the purification check added in #35839 rejects CREATE TABLE FROM SOURCE because the MySQL server is still in MINIMAL mode. Failure seen in https://buildkite.com/materialize/test/builds/120130#019d6892-80d9-4ae8-b919-814f200dc7ba Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bosconi
added a commit
that referenced
this pull request
Apr 7, 2026
Fixes merge skew between #35598 and #35839. `binlog-backward-compat.td` (from #35598) sets `binlog_row_metadata` to MINIMAL but never restores it. When sharded together with `upstream-schema-changes.td` (also from #35598), the purification check added in #35839 rejects `CREATE TABLE FROM SOURCE` because the MySQL server is still in MINIMAL mode. Failure seen in https://buildkite.com/materialize/test/builds/120130#019d6892-80d9-4ae8-b919-814f200dc7ba --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 task
mgree
pushed a commit
to mgree/materialize
that referenced
this pull request
Apr 13, 2026
…aterializeInc#35598) Implements a simple source versioning support for MySQL sources that relies on the upstream database setting `binlog_row_metadata = FULL`, guaranteeing that binlog row events will contain column names, making it quite easy to handle changes to upstream schemas. Updates docs, and creates a new test for this capability, and updates other tests with expected behavior.
mgree
pushed a commit
to mgree/materialize
that referenced
this pull request
Apr 13, 2026
Fixes merge skew between MaterializeInc#35598 and MaterializeInc#35839. `binlog-backward-compat.td` (from MaterializeInc#35598) sets `binlog_row_metadata` to MINIMAL but never restores it. When sharded together with `upstream-schema-changes.td` (also from MaterializeInc#35598), the purification check added in MaterializeInc#35839 rejects `CREATE TABLE FROM SOURCE` because the MySQL server is still in MINIMAL mode. Failure seen in https://buildkite.com/materialize/test/builds/120130#019d6892-80d9-4ae8-b919-814f200dc7ba --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a simple source versioning support for MySQL sources that relies on the upstream database setting
binlog_row_metadata = FULL, guaranteeing that binlog row events will contain column names, making it quite easy to handle changes to upstream schemas.Updates docs, and creates a new test for this capability, and updates other tests with expected behavior.