tests: Increase sleep in distinct_arrangements_mz_catalog_server.slt#35906
Merged
ggevay merged 1 commit intoMaterializeInc:mainfrom Apr 8, 2026
Merged
Conversation
Contributor
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
ggevay
force-pushed
the
fix-distinct_arrangements_mz_catalog_server.slt
branch
from
4ce9fbf to
4cb889c
Compare
teskje
approved these changes
Apr 8, 2026
ggevay
added a commit
that referenced
this pull request
Apr 11, 2026
…ery succeeded (#35908) When we do `--auto-index-selects`, if the normal query fails, then the error reporting gets quite complicated, and is currently buggy: We return `InconsistentViewOutcome` when the normal query fails but the view would fall under `INCONSISTENT_VIEW_OUTCOME_WARNING_REGEXPS`, making the error msg quite misleading. [Slack thread.](https://materializeinc.slack.com/archives/C01LKF361MZ/p1775637116095469?thread_ts=1775634600.931979&cid=C01LKF361MZ) So, this PR simplifies `--auto-index-selects`, by making it try the view only if the normal query succeeded. The rationale is that if the normal query failed, then we don't want to involve the whole complicated `--auto-index-selects` flow. This also allowed simplifying some more code. (Test run from before #35906 was merged to main, showing the new error: https://buildkite.com/materialize/test/builds/120200#019d6d16-44c4-4480-a7f3-1b6edaf8b084 )
mgree
pushed a commit
to mgree/materialize
that referenced
this pull request
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing
main.https://materializeinc.slack.com/archives/C01LKF361MZ/p1775642180579049?thread_ts=1775634600.931979&cid=C01LKF361MZ