Skip to content

expr: Fix missing aggregate variants in is_constant and propagates_nonnull_constraint#36061

Merged
def- merged 1 commit intoMaterializeInc:mainfrom
def-:pr-aggregate-func
Apr 14, 2026
Merged

expr: Fix missing aggregate variants in is_constant and propagates_nonnull_constraint#36061
def- merged 1 commit intoMaterializeInc:mainfrom
def-:pr-aggregate-func

Conversation

@def-
Copy link
Copy Markdown
Contributor

@def- def- commented Apr 14, 2026

No description provided.

@def- def- requested a review from ggevay April 14, 2026 04:55
@def- def- requested a review from a team as a code owner April 14, 2026 04:55
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone.

PR title guidelines

  • Use imperative mood: "Fix X" not "Fixed X" or "Fixes X"
  • Be specific: "Fix panic in catalog sync when controller restarts" not "Fix bug" or "Update catalog code"
  • Prefix with area if helpful: compute: , storage: , adapter: , sql:

Pre-merge checklist

  • The PR title is descriptive and will make sense in the git log.
  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).

@def- def- force-pushed the pr-aggregate-func branch from 5ff0a28 to b2fe623 Compare April 14, 2026 05:11
@def- def- changed the title expr: Propagate nonnull constraints through MaxInterval, MaxTime, MinInterval, MinTime expr: Fix missing aggregate variants in is_constant and propagates_nonnull_constraint Apr 14, 2026
@def- def- changed the title expr: Fix missing aggregate variants in is_constant and propagates_nonnull_constraint expr: Fix missing aggregate variants in is_constant and propagates_nonnull_constraint Apr 14, 2026
Copy link
Copy Markdown
Contributor

@ggevay ggevay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I also like the elimination of the wildcard!

@def- def- merged commit 15f2490 into MaterializeInc:main Apr 14, 2026
118 checks passed
@def- def- deleted the pr-aggregate-func branch April 14, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants