Skip to content

ALTER ROLE: Fix CREATEROLE check#36071

Merged
def- merged 2 commits intoMaterializeInc:mainfrom
def-:pr-fix-alter-role-check
Apr 15, 2026
Merged

ALTER ROLE: Fix CREATEROLE check#36071
def- merged 2 commits intoMaterializeInc:mainfrom
def-:pr-fix-alter-role-check

Conversation

@def-
Copy link
Copy Markdown
Contributor

@def- def- commented Apr 14, 2026

@def- def- requested a review from a team as a code owner April 14, 2026 09:53
@def- def- requested a review from ggevay April 14, 2026 09:53
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2026

Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone.

PR title guidelines

  • Use imperative mood: "Fix X" not "Fixed X" or "Fixes X"
  • Be specific: "Fix panic in catalog sync when controller restarts" not "Fix bug" or "Update catalog code"
  • Prefix with area if helpful: compute: , storage: , adapter: , sql:

Pre-merge checklist

  • The PR title is descriptive and will make sense in the git log.
  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).

@def- def- force-pushed the pr-fix-alter-role-check branch from 734d2d2 to 29e8597 Compare April 14, 2026 14:16
ggevay
ggevay reviewed Apr 14, 2026
View reviewed changes
Comment thread src/sql/src/rbac.rs Outdated
@def- @claude
sql: Use exhaustive pattern match for role attributes RBAC check
0d9ce10 
Address review feedback: use a non-wildcard pattern match on all fields
of PlannedRoleAttributes so the compiler catches any new fields added in
the future. Add comments explaining why nopassword/scram_iterations are
allowed (password-related) and why superuser is matched as None (handled
by a prior match arm).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@def- def- force-pushed the pr-fix-alter-role-check branch from 8642065 to 0d9ce10 Compare April 15, 2026 05:00
@def- def- requested a review from ggevay April 15, 2026 05:18
@def- def- merged commit a72f9ef into MaterializeInc:main Apr 15, 2026
118 checks passed
@def- def- deleted the pr-fix-alter-role-check branch April 15, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggevay ggevay ggevay approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@def- @ggevay