adapter,storage: fix replacement collection_metadata leak#36172
Merged
teskje merged 1 commit intoMaterializeInc:mainfrom Apr 21, 2026
Merged
adapter,storage: fix replacement collection_metadata leak#36172teskje merged 1 commit intoMaterializeInc:mainfrom
teskje merged 1 commit intoMaterializeInc:mainfrom
Conversation
This commit fixes a leak of storage `collection_metadata` entries when dropping replacement MVs without applying them. The previous code intentionally avoided adding the IDs of dropped replacements to `storage_collections_to_drop`, to avoid finalizing the shard, but causing the leak in doing so. The solution implemented here is to make `prepare_state` smarter and only finalize the shard if the dropped collection is a primary.
mtabebe
approved these changes
Apr 21, 2026
| assert not upper_empty | ||
|
|
||
|
|
||
| def workflow_github_11322(c: Composition) -> None: |
Contributor
Author
|
TFTR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a leak of storage
collection_metadataentries when dropping replacement MVs without applying them. The previous code intentionally avoided adding the IDs of dropped replacements tostorage_collections_to_drop, to avoid finalizing the shard, but causing the leak in doing so. The solution implemented here is to makeprepare_statesmarter and only finalize the shard if the dropped collection is a primary.Motivation
Fixes https://github.com/MaterializeInc/database-issues/issues/11322