testdrive: escape quotes and backslashes in rewrite_result#36488
Merged
Conversation
Values containing whitespace combined with `"` or `\` were wrapped in
quotes without escaping, causing the parser to either fail with
"unterminated quote" or silently corrupt expected values (e.g. `\n`
inside a path becomes a newline).
Introduce a small `escape_for_parser` helper that emits only the escape
sequences `parser::split_line` recognises (`\\`, `\"`, `\n`, `\t`, `\r`,
`\0`) and use it from both `rewrite_result` and `TestdriveRow::fmt`.
This avoids `format!("{:?}", …)`, whose Debug impl also emits `\u{N}`
for non-printable Unicode — escapes the parser does not understand and
would silently corrupt on the next read.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Values containing whitespace combined with
"or\were wrapped in quotes without escaping, causing the parser to either fail with "unterminated quote" or silently corrupt expected values (e.g.\ninside a path becomes a newline). Use Debug formatting like TestdriveRow::fmt does, which escapes exactly what split_line expects.