sql-pretty: Fix output of passwords and AS OF#36764
Merged
Merged
Conversation
def-
force-pushed
the
pr-sql-pretty
branch
2 times, most recently
from
5ec39d7 to
af23423
Compare
antiguru
approved these changes
May 28, 2026
Member
There was a problem hiding this comment.
We could probably add fuzz testing to ensure we don't miss statement parts?
Contributor
Author
There was a problem hiding this comment.
Yes, but I'll do that outside of this PR since it will probably end up being more involved.
|
yippee! 🎉 |
ggevay
reviewed
May 28, 2026
| ArrangeBy[[Column(0,␠"operator_id")]] 2 | ||
| ArrangeBy[[Column(1,␠"dataflow_id")]] 2 | ||
| ReduceAccumulable 3 | ||
| ReduceAccumulable 4 |
Contributor
There was a problem hiding this comment.
Hmm, do you know why this change happened?
Contributor
Author
There was a problem hiding this comment.
It was something else that hit main, not caused by my PR, same failure appeared in Nightly today: https://buildkite.com/materialize/nightly/builds/16598
So it's some change in this range: f1513fb...25f0e42
If it's important I can bisect later.
Contributor
There was a problem hiding this comment.
Ah, thanks! Maybe it's 3aa14b6. I'll run before and after to confirm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed in https://materializeinc.slack.com/archives/C085QFLB072/p1779932199965099