Skip to content

rust: Fix some compiler warnings about imports only being required with proptest#36767

Merged
def- merged 1 commit into
MaterializeInc:mainfrom
def-:pr-compiler-warnings
May 28, 2026
Merged

rust: Fix some compiler warnings about imports only being required with proptest#36767
def- merged 1 commit into
MaterializeInc:mainfrom
def-:pr-compiler-warnings

Conversation

@def-
Copy link
Copy Markdown
Contributor

@def- def- commented May 28, 2026

No description provided.

@def- def- force-pushed the pr-compiler-warnings branch from 1ced08e to 8de0743 Compare May 28, 2026 03:13
@def- def- force-pushed the pr-compiler-warnings branch from 8de0743 to 64cc536 Compare May 28, 2026 03:18
@def- def- changed the title rust: Fix some recent compiler warnings rust: Fix some compiler warnings about imports only being required with proptest May 28, 2026
@def- def- marked this pull request as ready for review May 28, 2026 03:18
@def- def- requested review from a team as code owners May 28, 2026 03:18
Copy link
Copy Markdown
Contributor

@ggevay ggevay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Copy Markdown
Member

@antiguru antiguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! My bad, missed this. Should we have a lint that checks that non-test builds don't have warnings?

@def- def- merged commit eb1148a into MaterializeInc:main May 28, 2026
119 checks passed
@def- def- deleted the pr-compiler-warnings branch May 28, 2026 15:40
@def-
Copy link
Copy Markdown
Contributor Author

def- commented May 28, 2026

Sure, let's do that: #36774

def- added a commit to def-/materialize that referenced this pull request May 29, 2026
def- added a commit that referenced this pull request May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants