Skip to content

Use enter_region to enter regions#4816

Merged
frankmcsherry merged 2 commits into
MaterializeInc:mainfrom
frankmcsherry:enter_region
Nov 17, 2020
Merged

Use enter_region to enter regions#4816
frankmcsherry merged 2 commits into
MaterializeInc:mainfrom
frankmcsherry:enter_region

Conversation

@frankmcsherry
Copy link
Copy Markdown
Contributor

@frankmcsherry frankmcsherry commented Nov 17, 2020

The methods enter_region and leave_region are specialized to cross scope boundaries without a map operator to transform timestamps as they go. This simplifies our dataflows slightly, in cases that we move collection streams across dataflows.


This change is Reviewable

Copy link
Copy Markdown
Contributor

@benesch benesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems smart!

Copy link
Copy Markdown
Contributor

@ruchirK ruchirK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants