Skip to content
This repository was archived by the owner on Dec 25, 2019. It is now read-only.

Parse positional parameters#17

Merged
benesch merged 1 commit intoMaterializeInc:masterfrom
JLDLaughlin:binding_wip
Oct 28, 2019
Merged

Parse positional parameters#17
benesch merged 1 commit intoMaterializeInc:masterfrom
JLDLaughlin:binding_wip

Conversation

@JLDLaughlin
Copy link
Copy Markdown
Contributor

@JLDLaughlin JLDLaughlin commented Oct 28, 2019

Start of what seemed necessary for: https://github.com/MaterializeInc/materialize/issues/822

Currently outputs the following error:

[2019-10-28T20:51:55.672957000Z WARN src/pgwire/codec.rs:184] error for client: Error->sql parser error: Unsupported value: Parameter("1")

@JLDLaughlin JLDLaughlin requested a review from benesch October 28, 2019 20:58
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Oct 28, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@benesch benesch changed the title WIP: Parse positional parameters Parse positional parameters Oct 28, 2019
@benesch
Copy link
Copy Markdown
Contributor

benesch commented Oct 28, 2019

Woo, thanks, Jessica!

@benesch benesch merged commit 5f22011 into MaterializeInc:master Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@benesch benesch Awaiting requested review from benesch

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JLDLaughlin @CLAassistant @benesch